I think there is a fair amount of medical evidence to the effect that smoking has an adverse effect on fitness. On the basis that for front-line troops at least, physical fitness is a definite advantage, maybe not smoking would be sensible.
Perhaps for those in military admin it would be OK. There would seem to be a fair amount of drug & alcohol abuse in the military, so perhaps set against that, not smoking wouldn't make a lot of difference.